Fixing label issue when columnType is null #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #4700 +/- ##
=======================================
Coverage 71.56% 71.56%
=======================================
Files 191 191
Lines 14958 14958
Branches 1100 1100
=======================================
Hits 10705 10705
Misses 4250 4250
Partials 3 3
Continue to review full report at Codecov.
|
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue where we shouldn't be showing the ColumnTypeLabel if columnType is null.
The tests didn't pick this up because expression was set for the column in the test (which maps to a specific columnType), so I fixed the tests and explicitly test for no column type if type is null.
@graceguo-supercat