Add yarn.lock #4674
Merged
Add yarn.lock #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4674 +/- ##
=======================================
Coverage 71.37% 71.37%
=======================================
Files 190 190
Lines 14918 14918
Branches 1102 1102
=======================================
Hits 10648 10648
Misses 4267 4267
Partials 3 3Continue to review full report at Codecov.
|
|
Do we need instructions on |
|
@mistercrunch Sure. I'll be happy to add. The instructions would be something along the lines of updating the yarn.lock file whenever you add a new javascript dependency? Anything else you would want me to add? |
This was referenced Mar 23, 2018
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Mar 30, 2018
(cherry picked from commit f11cde9)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making some improvements to our Dockerfile to better take advantage of the cache. Having a yarn.lock file will make that possible. It is also recommended in the yarn documentation ( https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/ last line).
Why was it removed in the first place? Is it a good idea to have it here?
I made sure to pull the latest superset version and run yarn before including the yarn.lock file
@graceguo-supercat @john-bodley @mistercrunch