Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set filter_select_enabled default to True for Druid #4608

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

mistercrunch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #4608 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4608      +/-   ##
==========================================
+ Coverage   71.18%   71.18%   +<.01%     
==========================================
  Files         189      189              
  Lines       14847    14848       +1     
  Branches     1086     1086              
==========================================
+ Hits        10569    10570       +1     
  Misses       4275     4275              
  Partials        3        3
Impacted Files Coverage Δ
superset/connectors/druid/models.py 76.35% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de44098...d488fe1. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo

@mistercrunch mistercrunch merged commit 1435840 into apache:master Mar 20, 2018
@mistercrunch mistercrunch deleted the enable_filter_druid branch March 20, 2018 05:15
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants