Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] fix shared explore url #4560

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Mar 7, 2018

Shared explore url was broken since #4490.
for user shared slice url: /superset/explore?r=123, there is no request or post params. need to add logic in get_form_data function, to get saved request params from url table.

@mistercrunch

@codecov-io
Copy link

Codecov Report

Merging #4560 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4560      +/-   ##
=========================================
- Coverage    71.2%   71.2%   -0.01%     
=========================================
  Files         187     187              
  Lines       14786   14785       -1     
  Branches     1083    1083              
=========================================
- Hits        10528   10527       -1     
  Misses       4255    4255              
  Partials        3       3
Impacted Files Coverage Δ
superset/views/core.py 71.15% <25%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b63dc91...40b5cde. Read the comment docs.

@michellethomas
Copy link
Contributor

lgtm

@graceguo-supercat graceguo-supercat changed the title [bug] fix shortener url [bug] fix shared explore url Mar 7, 2018
@graceguo-supercat graceguo-supercat merged commit 369f652 into apache:master Mar 7, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Mar 7, 2018
(cherry picked from commit 369f652)
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Mar 7, 2018
@graceguo-supercat graceguo-supercat deleted the gg-FixShortnedExploreUrl branch March 8, 2018 22:06
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Mar 13, 2018
[bug] fix shared explore url

(cherry picked from commit 369f652)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
[bug] fix shared explore url
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
[bug] fix shared explore url
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants