Superset issue #4512: fixing histogram #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
reviewed
Mar 1, 2018
| @@ -1086,7 +1086,8 @@ export const visTypes = { | |||
| label: t('Chart Options'), | |||
| controlSetRows: [ | |||
| ['color_scheme'], | |||
| ['link_length'], | |||
| ['link_length', 'x_axis_label'], | |||
There was a problem hiding this comment.
Can we add the y_axis_label here too?
Closed
|
@hughhhh @mistercrunch I have another commit in store that I want to push. Should I
The new commit is more involved (adding group by option, multiple metrics, legends, etc) |
|
@ArielStv Merged! |
|
thanks a lot! |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* fixing histogram axes and colors, adding normalized and x-axis label options * adding y-axis label option
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* fixing histogram axes and colors, adding normalized and x-axis label options * adding y-axis label option
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address issue #4512.