Expose hook to inject database connection logic on the fly #4505

mistercrunch · 2018-03-01T01:33:35Z

This environment configuration setting hook allows administrators to
alter the database connection parameters on the fly based on user
information. This can be use for a variety of purposes:

rewire a subset of users to use different database user accounts
pass user related information to the database for logging or QoS
purposes
custom, per-database-engine, environment-specific impersonation

This environment configuration setting hook allows administrators to alter the database connection parameters on the fly based on user information. This can be use for a variety of purposes: * rewire a subset of users to use different database user accounts * pass user related information to the database for logging or QoS purposes * ...

nishantrayan · 2018-03-01T18:54:42Z

superset/config.py

@@ -377,6 +377,22 @@ class CeleryConfig(object):
 # an XSS security vulnerability
 ENABLE_JAVASCRIPT_CONTROLS = False

+# A callable that allows altering the database conneciton URL and params
+# on the fly, at runtime. This allows for things like impersonation or
+# arbitrary logic. For instance you could wired different users to


s/you could wired/you can wire/g

mistercrunch · 2018-03-07T06:35:42Z

This is a pretty benign, just a hook we need in our env, mergin'

* Expose hook to inject database connection logic on the fly This environment configuration setting hook allows administrators to alter the database connection parameters on the fly based on user information. This can be use for a variety of purposes: * rewire a subset of users to use different database user accounts * pass user related information to the database for logging or QoS purposes * ... * Fixes

* Expose hook to inject database connection logic on the fly This environment configuration setting hook allows administrators to alter the database connection parameters on the fly based on user information. This can be use for a variety of purposes: * rewire a subset of users to use different database user accounts * pass user related information to the database for logging or QoS purposes * ... * Fixes (cherry picked from commit b63dc91)

* Expose hook to inject database connection logic on the fly This environment configuration setting hook allows administrators to alter the database connection parameters on the fly based on user information. This can be use for a variety of purposes: * rewire a subset of users to use different database user accounts * pass user related information to the database for logging or QoS purposes * ... * Fixes

nishantrayan reviewed Mar 1, 2018

View reviewed changes

Fixes

ee755ef

mistercrunch merged commit b63dc91 into apache:master Mar 7, 2018

mistercrunch deleted the mutate_db_conn branch March 7, 2018 06:35

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose hook to inject database connection logic on the fly #4505

Expose hook to inject database connection logic on the fly #4505

mistercrunch commented Mar 1, 2018 •

edited

Loading

nishantrayan Mar 1, 2018

mistercrunch commented Mar 7, 2018

Expose hook to inject database connection logic on the fly #4505

Expose hook to inject database connection logic on the fly #4505

Conversation

mistercrunch commented Mar 1, 2018 • edited Loading

nishantrayan Mar 1, 2018

Choose a reason for hiding this comment

mistercrunch commented Mar 7, 2018

mistercrunch commented Mar 1, 2018 •

edited

Loading