Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove html tag in timeout error message #4447

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Feb 16, 2018

@timifasubaa
Copy link
Contributor

Would it be better to allow the error message be rendered as html as opposed to string so the title can be bold?

@mistercrunch
Copy link
Member

LGTM

@timifasubaa we removed all the DangerouslySetInnerHtml calls resently as they represent a vector of script injection. The alternative is to consider the error message as a React nodeas it gets passed around, though it may flow through Redux in which case it may be an anti-pattern to put nodes in the Redux store.

The easy & secure solution is to remove the tags.

@graceguo-supercat graceguo-supercat merged commit 15aa0c5 into apache:master Feb 17, 2018
@graceguo-supercat graceguo-supercat deleted the gg-RemoveHTMLTagInTimeoutMessage branch February 21, 2018 19:15
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants