Add link on how to get permission to permission error #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
add_steps_to_get_permission
branch
from
ce4c721
to
2c762f1
Compare
|
PING |
timifasubaa
changed the title
john-bodley
reviewed
Feb 14, 2018
superset/views/core.py
Outdated
| perms_instruction_link = config.get('PERMISSION_INSTRUCTIONS_LINK') | ||
| if perms_instruction_link: | ||
| DATASOURCE_ACCESS_ERR = __( | ||
| "You don't have access to this datasource. <a href='{}'>How to gain access.</a>" |
There was a problem hiding this comment.
I think this is fine. If you wanted to truncate the length of the message maybe something like
You don't have access to this datasource (Gain Access)
|
Pending #4405 I think this LGTM, my only comment was possibly on abbreviating the language. |
timifasubaa
changed the title
|
Unrelated to this PR: we need padding on the |
|
Language abbreviated. |
|
I don't think this works with #4373 |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* add flag to config * add troubleshooting link if there is a link * nits
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* add flag to config * add troubleshooting link if there is a link * nits
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a way for users to be shown a link to a document that shows them how to gain the right permissions to be able to access datasources. This often varies across companies so it is manually configured in the config file. If set, the end result should look like the image below.
@john-bodley @michellethomas @mistercrunch