[geo] JS function to receive the whole data array instead on individual objects #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al object Moving from having the user define an interceptor function that operates on one object at a time. By passing the entire array, it's possible to do multiple pass where needed. A common pattern might be to figure out the max value in order to define a scaler function. That's only possible if dealing with the whole array.
hughhhh
reviewed
Jan 23, 2018
| let jsFnMutator; | ||
| if (fd.js_datapoint_mutator) { | ||
| if (fd.js_data_mutator) { |
There was a problem hiding this comment.
nit: later on we should have some type of baseComponentClass for the components so we aren't copying this condition into each layer.
What are your thoughts? @mistercrunch
|
🚢 |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…al object (apache#4262) Moving from having the user define an interceptor function that operates on one object at a time. By passing the entire array, it's possible to do multiple pass where needed. A common pattern might be to figure out the max value in order to define a scaler function. That's only possible if dealing with the whole array.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…al object (apache#4262) Moving from having the user define an interceptor function that operates on one object at a time. By passing the entire array, it's possible to do multiple pass where needed. A common pattern might be to figure out the max value in order to define a scaler function. That's only possible if dealing with the whole array.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from having the user define an interceptor function that operates
on one object at a time to passing the whole array.
By passing the entire array, it's possible to do multiple passes where
needed. A common pattern might be to figure out a max value of a prop in order
to define a scaler function. That's only possible if dealing with the
whole array.
No change management is necessary as this feature has not been officially released yet.