Fix 'argument to reversed() must be a sequence' #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing empty/null location data out of certain rows in the spatial control, Superset raises an error when trying to reverse the tuple.
mistercrunch
force-pushed
the
fix_reversed
branch
from
dfb0125
to
f9d8914
Compare
hughhhh
reviewed
Jan 18, 2018
| @@ -1852,7 +1852,10 @@ def process_spatial_data_obj(self, key, df): | |||
| elif spatial.get('type') == 'delimited': | |||
| df[key] = (df[spatial.get('lonlatCol')].str.split(spatial.get('delimiter'))) | |||
| if spatial.get('reverseCheckbox'): | |||
| df[key] = [list(reversed(item))for item in df[key]] | |||
| df[key] = [ | |||
| tuple(reversed(o)) if isinstance(o, (list, tuple)) else (0, 0) | |||
There was a problem hiding this comment.
Is there a way for us to give the user a warning about that some of the reversed values weren't converted properly?
There was a problem hiding this comment.
It'd be somewhat tricky from this context. On the JS side we can notify.warning("Foo bar") but there are no easy mechanics from this context.
|
🚢 |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
When passing empty/null location data out of certain rows in the spatial control, Superset raises an error when trying to reverse the tuple.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
When passing empty/null location data out of certain rows in the spatial control, Superset raises an error when trying to reverse the tuple.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing empty/null location data out of certain rows in the spatial
control, Superset raises an error when trying to reverse the tuple.