-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an "Edit Mode" to Dashboard view #3940
Conversation
Hi Max, thanks for adding 'Edit Mode'. I have a question, please see the attached example: |
Right, we need to allow for "Save As" in view mode. I had missed that. Let me add it back. Note that changing the filter does not trigger the "has changed" notification. |
@graceguo-supercat I addressed your comment |
@mistercrunch It looks good to me. Only 1 question to clarify: all of the components' |
@graceguo-supercat good point, I meant to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add a togglable edit mode to dashboard * Submenu for controls * Allowing 'Save as' outside of editMode * Set editMode to false as default
* Add a togglable edit mode to dashboard * Submenu for controls * Allowing 'Save as' outside of editMode * Set editMode to false as default
What changes when toggling between edit/view mode: