minor filter select enhancements #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkalyan
changed the title
Mogball
reviewed
Nov 27, 2017
There was a problem hiding this comment.
Overall looks good. If you could also add 2/3 tests to verify this here https://github.com/apache/incubator-superset/blob/master/superset/assets/spec/javascripts/explore/components/FilterControl_spec.jsx it'd be 👍
superset/config.py
Outdated
| @@ -41,6 +41,8 @@ | |||
|
|
|||
| ROW_LIMIT = 50000 | |||
| VIZ_ROW_LIMIT = 10000 | |||
| # max rows retrived by filter select auto complete | |||
| @@ -28,6 +28,7 @@ export default class FilterControl extends React.Component { | |||
| })); | |||
| this.state = { | |||
| filters: initialFilters, | |||
| xhr: null, | |||
There was a problem hiding this comment.
I would rename this to activeRequest or something more descriptive
| $.ajax({ | ||
| // if there is an outstanding request to fetch values, cancel it. | ||
| if (this.state.xhr) this.state.xhr.abort(); | ||
| this.setState({ xhr: $.ajax({ |
There was a problem hiding this comment.
please format this section of code
this.setState({
xhr: $.ajax({
...
})
});
Mogball
approved these changes
Nov 28, 2017
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* `values_for_column` configurable row limit * `FilterControl` cancels active ajax request if any
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* `values_for_column` configurable row limit * `FilterControl` cancels active ajax request if any
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter selectis hardcoded to 10K in the code, this PR makes the limit configurable.