[BUGFIX]: Fixing dttm_sql_literal to use python_date_format #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis never fired for this one, maybe pushing a new commit on top will trigger it? |
fabianmenges
force-pushed
the
fmenges/python_date_format
branch
from
747c81c
to
31b94de
Compare
|
should be good now |
Mogball
approved these changes
Dec 6, 2017
|
We just noticed this issue the other day, thanks for fixing! |
john-bodley
reviewed
Dec 7, 2017
There was a problem hiding this comment.
Echoing @Michelle-Thomas’s sentiments, this LGTM, though I wonder if we should add a unit test for this given the regression.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between this
orhttps://github.com/apache/incubator-superset/blob/fa35d7d2f47d2f5b664d0433ea1be677924767e6/superset/connectors/sqla/models.py#L105
and this
orhttps://github.com/apache/incubator-superset/blob/fa35d7d2f47d2f5b664d0433ea1be677924767e6/superset/connectors/sqla/models.py#L114
You can get in a situation where
python_date_formatis completely ignored. This fixes this.