-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to specify label->color mapping #3879
Conversation
This is out of scope of this change, but I feel like we should have a UI to do this and not just manually writing json into this metadata field. Apart from that I find it extremely difficult to find documentation (e.g. why is a very specific dashboard feature mentioned in a FAQ) for these kinds of features, we should probably reorganize our docs by functionality. Have a single doc for all the things you can specify on dashboard. |
Totally agree about the docs, I think about this every time I add an FAQ entry. It's just always out-of-scope for the particular thing I work on to reorg the docs. Let's talk about this item briefly at the meeting tomorrow. |
Also agree about having this in the UI and that's true of most of the things in "Metadata JSON". I think it's a good pattern to have a way to add features for power users that are scaffolding for future UX components. This allows us to roll out key features with a fraction of the dev time, and we can always finish up the work later based on usage/popularity. This is especially good for uncommon-but-required features. I wonder if there was a halfway between free-form JSON, and the UX features, say a little JSON editor that forces certain shapes and types. |
Waiting for #3887 to rebase against |
Users can define `label_colors` in a dashboard's JSON metadata that enforces a label to color mapping. This also makes the function that maps labels to colors case insensitive.
e73c1b5
to
f0bb6e6
Compare
@mistercrunch @fabianmenges we have been discussing adding global If we're going to do a decent amount of work on the dashboards I don't think we should have a partial UI for it, we should just do it properly :) this is great for the logic component. |
Users can define `label_colors` in a dashboard's JSON metadata that enforces a label to color mapping. This also makes the function that maps labels to colors case insensitive. (cherry picked from commit a82bb58)
Users can define `label_colors` in a dashboard's JSON metadata that enforces a label to color mapping. This also makes the function that maps labels to colors case insensitive.
Users can define `label_colors` in a dashboard's JSON metadata that enforces a label to color mapping. This also makes the function that maps labels to colors case insensitive.
Users can define
label_colors
in a dashboard's JSON metadata that enforces a label to color mapping.It's common for user to want certain series to be a specific color ('forecast' should be a blue line, 'actual' is green), or to want consistency across dashboard refreshes (which we don't provide at the moment)
This also makes the function that maps labels to colors case insensitive.
@michellethomas @graceguo-supercat @williaster @john-bodley
BTW it could be nice to allow global settings (apply to all dashboards) for this somewhere.