Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard bug]Fix userId prop in Explore view Save_Modal #3857

Merged

Conversation

graceguo-supercat
Copy link

For userId, the attribute name in bootstrap data is user_id.

@michellethomas @mistercrunch

For userId, the attribute name in bootstrap data is user_id
@michellethomas
Copy link
Contributor

lgtm

@graceguo-supercat graceguo-supercat merged commit 3f076b0 into apache:master Nov 14, 2017
@graceguo-supercat graceguo-supercat deleted the gg-FixUserIdPropInSaveModal branch November 14, 2017 04:52
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
For userId, the attribute name in bootstrap data is user_id
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
For userId, the attribute name in bootstrap data is user_id
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants