Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8] Resolving C??? errors #3787

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

john-bodley
Copy link
Member

This PR resolves all the C??? violation codes which enforces trailing commas which is helpful to avoid issues related to merge conflicts and helps to enforce consistency.

to: @mistercrunch

@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage remained the same at 71.465% when pulling 814b9c1776ddd94a96d7265d1eafd10a85901cfe on john-bodley:john-bodley-flake8-C into ccb87d3 on apache:master.

@john-bodley john-bodley force-pushed the john-bodley-flake8-C branch 2 times, most recently from 209ad3e to d029850 Compare November 7, 2017 19:11
@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage remained the same at 71.465% when pulling d029850e5ab3b6d3007dd505b4049246eba39ac1 on john-bodley:john-bodley-flake8-C into b10aca2 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.465% when pulling d029850e5ab3b6d3007dd505b4049246eba39ac1 on john-bodley:john-bodley-flake8-C into b10aca2 on apache:master.

@coveralls
Copy link

coveralls commented Nov 8, 2017

Coverage Status

Coverage remained the same at 71.445% when pulling 4fdd230 on john-bodley:john-bodley-flake8-C into 7453131 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.445% when pulling 4fdd230 on john-bodley:john-bodley-flake8-C into 7453131 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.445% when pulling 4fdd230 on john-bodley:john-bodley-flake8-C into 7453131 on apache:master.

@mistercrunch mistercrunch merged commit 17623f7 into apache:master Nov 8, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants