Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dependency on pythrifthiveapi #3494

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Removing dependency on pythrifthiveapi #3494

merged 1 commit into from
Sep 19, 2017

Conversation

mistercrunch
Copy link
Member

Since the latest pyhive, we don't need pythrifthiveapi as they ship with
the latest version.

There's actually a conflict between the new pyhive and pythrifthiveapi
and this fixes it.

@mistercrunch
Removing dependency on pythrifthiveapi
e8a0a73 
Since the latest pyhive, we don't need pythrifthiveapi as they ship with
the latest version.

There's actually a conflict between the new pyhive and pythrifthiveapi
and this fixes it.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.432% when pulling e8a0a73 on mistercrunch:pythrifthiveapi into c5252d0 on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 69.432% when pulling e8a0a73 on mistercrunch:pythrifthiveapi into c5252d0 on apache:master.

nishantmonu51
nishantmonu51 approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timifasubaa
Copy link
Contributor

LGTM

@mistercrunch mistercrunch merged commit ccd5fd4 into apache:master Sep 19, 2017
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request Oct 3, 2017
@mistercrunch @timifasubaa
Removing dependency on pythrifthiveapi (apache#3494)
ea6b078 
Since the latest pyhive, we don't need pythrifthiveapi as they ship with
the latest version.

There's actually a conflict between the new pyhive and pythrifthiveapi
and this fixes it.
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Removing dependency on pythrifthiveapi (apache#3494)
e059730 
Since the latest pyhive, we don't need pythrifthiveapi as they ship with
the latest version.

There's actually a conflict between the new pyhive and pythrifthiveapi
and this fixes it.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantmonu51 nishantmonu51 nishantmonu51 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistercrunch @coveralls @timifasubaa @nishantmonu51