Allow for multiple color schemes #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. create ColorSchemeControl component 2. using the same new control component for linear colors
1 similar comment
mistercrunch
approved these changes
Aug 15, 2017
| return ( | ||
| <div> | ||
| <ControlHeader {...this.props} /> | ||
| {selectWrap} |
There was a problem hiding this comment.
nit: not sure what the value of the selectWrap is, you could just have the <Creatable here
| autosize: false, | ||
| clearable: false, | ||
| onChange: this.onChange, | ||
| optionRenderer: opt => this.optionRender(opt.value), |
There was a problem hiding this comment.
nit: if optionRender expected to receive and option, you could just optionRenderer: this. optionRender here. Also nit could rename to renderOption or optionRenderer
1 similar comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #3258