Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js-tests] SqlLab actions - tests for saveQuery, fetchQueryResults, runQuery, postStopQuery #2979

Merged
merged 1 commit into from
Jun 15, 2017
Merged

[js-tests] SqlLab actions - tests for saveQuery, fetchQueryResults, runQuery, postStopQuery #2979

merged 1 commit into from
Jun 15, 2017

Conversation

ascott
Copy link
Contributor

@ascott ascott commented Jun 15, 2017

#2850

we could use some more tests on this file, but adding this for now.

@graceguo-supercat @mistercrunch

graceguo-supercat
graceguo-supercat approved these changes Jun 15, 2017
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ascott ascott merged commit 6ddccaa into apache:master Jun 15, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascott @graceguo-supercat @mistercrunch