Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new slice test #2939

Merged
merged 5 commits into from
Jun 13, 2017
Merged

add new slice test #2939

merged 5 commits into from
Jun 13, 2017

Conversation

ascott
Copy link

@ascott ascott commented Jun 9, 2017

  • explicitly sort on label
  • add simple test for /slicemodelview/add

@SalehHindi @mistercrunch

@ascott ascott mentioned this pull request Jun 9, 2017
Closed
mistercrunch
mistercrunch approved these changes Jun 12, 2017
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascott ascott merged commit e1751c0 into apache:master Jun 13, 2017
@ascott ascott deleted the alanna-add-slice-test branch June 13, 2017 16:44
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Jun 13, 2017
add new slice test (apache#2939)
1422f26 
* sort explicitly on label

* add simple test for /slicemodelview/add endpoint

* make comments and method names more clear

* fix test name

* be more explicit, test status_code
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.18.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascott @mistercrunch