feat: alert/report execution log list view #11937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11937 +/- ##
==========================================
- Coverage 63.59% 54.57% -9.03%
==========================================
Files 939 431 -508
Lines 45580 15160 -30420
Branches 4371 3874 -497
==========================================
- Hits 28988 8273 -20715
+ Misses 16416 6887 -9529
+ Partials 176 0 -176
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
reviewed
Dec 8, 2020
superset-frontend/src/views/CRUD/alert/components/AlertStatusIcon.tsx
Outdated
Show resolved
Hide resolved
lilykuang
force-pushed
the
lily/alert-execution-log
branch
from
afa7bed to
90e3899
Compare
nytai
approved these changes
Dec 10, 2020
| const handleEdit = () => {}; // handleAnnotationEdit(original); | ||
| const handleDelete = () => {}; // setAlertCurrentlyDeleting(original); | ||
| const hanldeGotoExecutionLog = () => |
There was a problem hiding this comment.
Suggested change
| const hanldeGotoExecutionLog = () => | |
| const handleGotoExecutionLog = () => |
| tooltip: t('Execution Log'), | ||
| placement: 'bottom', | ||
| icon: 'note' as IconName, | ||
| onClick: handleEdit, | ||
| onClick: hanldeGotoExecutionLog, |
There was a problem hiding this comment.
Suggested change
| onClick: hanldeGotoExecutionLog, | |
| onClick: handleGotoExecutionLog, |
nytai
reviewed
Dec 10, 2020
| addDangerToast, | ||
| ); | ||
|
|
||
| const [alert, setAlert] = useState<AlertObject | null>(null); |
There was a problem hiding this comment.
Do we still need this? Isn't alertResource the same thing?
There was a problem hiding this comment.
dont really need this. I will remove this line of code
nytai
reviewed
Dec 10, 2020
Comment on lines
76
to
78
| if (alertId !== null && !alertLoading) { | ||
| fetchResource(alertId); | ||
| } |
There was a problem hiding this comment.
I haven't tested this, but it looks like this would cause an infinite fetch loop. Let's wrap it in a useEffect to be safe
Suggested change
| if (alertId !== null && !alertLoading) { | |
| fetchResource(alertId); | |
| } | |
| useEffect(() => { | |
| if (alertId !== null) { | |
| fetchResource(alertId); | |
| } | |
| }, [alertId]) | |
There was a problem hiding this comment.
yup, just tested this. It results in an infinite fetchResource loop
added 10 commits
December 10, 2020 12:26
lilykuang
force-pushed
the
lily/alert-execution-log
branch
from
350102c to
0b120b2
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Back to allredirect back to alert/report listBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Alert Execution Log
Report Execution Log
TEST PLAN
ADDITIONAL INFORMATION