feat: filter by me on CRUD list view #11683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11683 +/- ##
===========================================
- Coverage 67.30% 55.05% -12.25%
===========================================
Files 905 411 -494
Lines 43872 14535 -29337
Branches 4202 3729 -473
===========================================
- Hits 29527 8002 -21525
+ Misses 14241 6533 -7708
+ Partials 104 0 -104
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
reviewed
Nov 13, 2020
| ({ text: label, value }: { text: string; value: any }) => ({ | ||
| label, | ||
| value, | ||
| }), | ||
| ); | ||
|
|
||
| return options.concat(data); |
There was a problem hiding this comment.
I believe some of these results are paginated so each request will end up with multiple me entries.
There was a problem hiding this comment.
Actually, nvm. Looks like these results are merged in with the existing ones and get properly deduped. 👍
riahk
approved these changes
Nov 13, 2020
| ) => async (filterValue = '', pageIndex?: number, pageSize?: number) => { | ||
| const resourceEndpoint = `/api/v1/${resource}/${method}/${relation}`; | ||
|
|
||
| const options = | ||
| userId && pageIndex === 0 ? [{ label: 'me', value: userId }] : []; |
There was a problem hiding this comment.
small nit, but should me be capitalized?
lilykuang
force-pushed
the
lily/filter-by-me
branch
from
d481a51 to
24e6866
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implement filter with
Meoption for list views:BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION