[SEDONA-197] Added ST_ZMax and ST_ZMin to Apache Sedona #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Nov 22, 2022
There was a problem hiding this comment.
Please add the following:
- DataFrameAPI for Spark, with tests: https://github.com/apache/incubator-sedona/blob/master/sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala
- Corresponding function in Flink, with tests: https://github.com/apache/incubator-sedona/blob/master/flink/src/main/java/org/apache/sedona/flink/Catalog.java#L21
…ing functions in Flink
jiayuasu
requested changes
Nov 22, 2022
There was a problem hiding this comment.
Looks good to me. One last thing: please add the DataFrame style API to Python as well -> https://github.com/apache/incubator-sedona/blob/master/python/sedona/sql/st_functions.py
jiayuasu
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Added ST_ZMax and ST_ZMin functions to SQL
How was this patch tested?
Through unit tests written in Scala
Did this PR include necessary documentation updates?