-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only inserted fields #719
Open
lxfeng1997
wants to merge
2
commits into
apache:master
Choose a base branch
from
lxfeng1997:only_inserted_fields
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
only inserted fields #719
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -132,9 +132,12 @@ func (u *MySQLInsertUndoLogBuilder) buildAfterImageSQL(ctx context.Context, exec | |
} | ||
// build check sql | ||
sb := strings.Builder{} | ||
sb.WriteString("SELECT * FROM " + tableName) | ||
suffix := strings.Builder{} | ||
sb.WriteString("SELECT " + strings.Join(pkColumnNameList, ", ")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 同理如上 |
||
suffix.WriteString(" FROM " + tableName) | ||
whereSQL := u.buildWhereConditionByPKs(pkColumnNameList, len(pkValuesMap[pkColumnNameList[0]]), "mysql", maxInSize) | ||
sb.WriteString(" WHERE " + whereSQL + " ") | ||
suffix.WriteString(" WHERE " + whereSQL + " ") | ||
sb.WriteString(suffix.String()) | ||
return sb.String(), u.buildPKParams(pkRowImages, pkColumnNameList), nil | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -138,8 +138,26 @@ func (u *MySQLMultiUpdateUndoLogBuilder) AfterImage(ctx context.Context, execCtx | |
|
||
func (u *MySQLMultiUpdateUndoLogBuilder) buildAfterImageSQL(beforeImage *types.RecordImage, meta types.TableMeta) (string, []driver.Value) { | ||
sb := strings.Builder{} | ||
// todo use ONLY_CARE_UPDATE_COLUMNS to judge select all columns or not | ||
sb.WriteString("SELECT * FROM " + meta.TableName + " ") | ||
var selectFieldsStr string | ||
selectFields := make([]string, 0, len(meta.ColumnNames)) | ||
var fieldsExits = make(map[string]struct{}) | ||
if undo.UndoConfig.OnlyCareUpdateColumns { | ||
for _, row := range beforeImage.Rows { | ||
for _, column := range row.Columns { | ||
if _, exist := fieldsExits[column.ColumnName]; exist { | ||
continue | ||
} | ||
|
||
fieldsExits[column.ColumnName] = struct{}{} | ||
selectFields = append(selectFields, column.ColumnName) | ||
} | ||
} | ||
selectFieldsStr = strings.Join(selectFields, ",") | ||
} else { | ||
selectFieldsStr = strings.Join(meta.ColumnNames, ",") | ||
} | ||
|
||
sb.WriteString("SELECT " + selectFieldsStr + " FROM " + meta.TableName + " ") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. insert_test 单元测试得修改下 |
||
whereSQL := u.buildWhereConditionByPKs(meta.GetPrimaryKeyOnlyName(), len(beforeImage.Rows), "mysql", maxInSize) | ||
sb.WriteString(" " + whereSQL + " ") | ||
return sb.String(), u.buildPKParams(beforeImage.Rows, meta.GetPrimaryKeyOnlyName()) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里只 select 主键字段吗?应该是选择 insert 中带的字段比较合理?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外,除了要把 insert 的字段查出来,还需要把有默认值的字段也查出来?这些字段的修改也可能导致脏回滚