only inserted fields #719
Open
only inserted fields #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
luky116
reviewed
Dec 7, 2024
| selectFieldsStr = strings.Join(meta.ColumnNames, ",") | ||
| } | ||
|
|
||
| sb.WriteString("SELECT " + selectFieldsStr + " FROM " + meta.TableName + " ") |
luky116
reviewed
Dec 7, 2024
| @@ -184,9 +184,12 @@ func (i *insertExecutor) buildAfterImageSQL(ctx context.Context) (string, []driv | |||
| } | |||
| // build check sql | |||
| sb := strings.Builder{} | |||
| sb.WriteString("SELECT * FROM " + tableName) | |||
| suffix := strings.Builder{} | |||
| sb.WriteString("SELECT " + strings.Join(pkColumnNameList, ", ")) | |||
There was a problem hiding this comment.
这里只 select 主键字段吗？应该是选择 insert 中带的字段比较合理？
There was a problem hiding this comment.
另外，除了要把 insert 的字段查出来，还需要把有默认值的字段也查出来？这些字段的修改也可能导致脏回滚
luky116
reviewed
Dec 7, 2024
| @@ -132,9 +132,12 @@ func (u *MySQLInsertUndoLogBuilder) buildAfterImageSQL(ctx context.Context, exec | |||
| } | |||
| // build check sql | |||
| sb := strings.Builder{} | |||
| sb.WriteString("SELECT * FROM " + tableName) | |||
| suffix := strings.Builder{} | |||
| sb.WriteString("SELECT " + strings.Join(pkColumnNameList, ", ")) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
optimize: only the inserted fields are checked
Which issue(s) this PR fixes:
#697
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: