Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 609,610,611 #612

Merged
merged 3 commits into from
Feb 3, 2024
Merged

fix issue 609,610,611 #612

merged 3 commits into from
Feb 3, 2024

Conversation

576470954
Copy link
Contributor

What this PR does:
fix bug

Which issue(s) this PR fixes:

Fixes #609 #610 #611

Special notes for your reviewer:
about issue #611 , I found it have not release the conn, when the conn inited and not used(by condition cache have store the info)
image

Does this PR introduce a user-facing change?:

Fixes #609 #610 #611 

@576470954
Copy link
Contributor Author

about issue #611 , may be close the conn at this position may be better
image

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c5fc98a) 37.28% compared to head (7a8b376) 37.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   37.28%   37.28%   -0.01%     
==========================================
  Files         175      175              
  Lines       11666    11667       +1     
==========================================
  Hits         4350     4350              
- Misses       6952     6953       +1     
  Partials      364      364              
Files Coverage Δ
pkg/datasource/sql/conn_at.go 48.81% <0.00%> (-0.39%) ⬇️
...tasource/sql/exec/at/select_for_update_executor.go 30.23% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iSuperCoder iSuperCoder requested a review from luky116 September 27, 2023 09:59
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luky116 luky116 merged commit 9709b35 into apache:master Feb 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT mode queryContext func (select for update )got error:
5 participants