Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-go 将 seata-golang替换为seata-go #252

Closed
luky116 opened this issue Sep 3, 2022 · 11 comments
Closed

dubbo-go 将 seata-golang替换为seata-go #252

luky116 opened this issue Sep 3, 2022 · 11 comments
Assignees

Comments

@luky116
Copy link
Contributor

luky116 commented Sep 3, 2022

What would you like to be added:
https://github.com/apache/dubbo-go-samples/tree/1.5/shopping-order

Why is this needed:

@Issues-translate-bot
Copy link

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Title: dubbo-go replaces seata-golang with seata-go

@betterwinsone
Copy link
Contributor

Assign to me

@luky116
Copy link
Contributor Author

luky116 commented Sep 4, 2022

betterwinsone

ok

@betterwinsone
Copy link
Contributor

image
给dubbo-go-samples 增加seata-go例子的时候报错了。
排查发现是seata-go使用的github.com/dubbogo/gost 是v1.12.5版本,而dubbo-go-samples 使用的是v1.11.21-0.20220503144918-9e5ae44480af 版本比较老,seata-go引入到dubbo-go-samples后,会自动升级github.com/dubbogo/gost 到v1.12.5版本,就导致了截图中的错误,是否可以将seata-go的例子提交到dubbo-go-samples master分支?我看dubbo-go-samples master分支使用的github.com/dubbogo/gost 的版本也是v1.12.5,应该就不会报错了 @luky116 @AlexStocks

@Issues-translate-bot
Copy link

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


image
An error was reported when adding a seata-go example to dubbo-go-samples.
The investigation found that github.com/dubbogo/gost used by seata-go is version v1.12.5, while dubbo-go-samples uses v1.11.21-0.20220503144918-9e5ae44480af version is relatively old, and seata-go is introduced into dubbo-go- After the samples, github.com/dubbogo/gost will be automatically upgraded to v1.12.5, which leads to the error in the screenshot. Is it possible to submit the seata-go example to the dubbo-go-samples master branch? I see dubbo-go The version of github.com/dubbogo/gost used by the -samples master branch is also v1.12.5, so there should be no error @luky116 @AlexStocks

@AlexStocks
Copy link
Contributor

尝试把版本升级到 3.0.2 试试

@Issues-translate-bot
Copy link

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Try to upgrade the version to 3.0.2 try

@betterwinsone
Copy link
Contributor

已提交,检查通过,等待合并 apache/dubbo-go-samples#418

@Issues-translate-bot
Copy link

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Submitted, checked, waiting to be merged apache/dubbo-go-samples#418

@betterwinsone
Copy link
Contributor

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants