From 34bc4be5afa55aa9098bbb746286dcd51b985bbc Mon Sep 17 00:00:00 2001 From: Dan Wang Date: Wed, 27 Nov 2024 12:48:25 +0800 Subject: [PATCH 1/2] feat(remote_command): allow empty writes to be queried/enabled/disabled by remote command --- src/replica/replica_stub.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/replica/replica_stub.cpp b/src/replica/replica_stub.cpp index 6389ed50c0..cad0d4d786 100644 --- a/src/replica/replica_stub.cpp +++ b/src/replica/replica_stub.cpp @@ -229,6 +229,7 @@ METRIC_DEFINE_gauge_int64(server, "The max size of copied files among all splitting replicas"); DSN_DECLARE_bool(duplication_enabled); +DSN_DECLARE_bool(empty_write_disabled); DSN_DECLARE_bool(enable_acl); DSN_DECLARE_bool(encrypt_data_at_rest); DSN_DECLARE_int32(fd_beacon_interval_seconds); @@ -2354,6 +2355,12 @@ void replica_stub::register_ctrl_command() }); })); + _cmds.emplace_back(::dsn::command_manager::instance().register_bool_command( + FLAGS_empty_write_disabled, + FLAGS_empty_write_disabled, + "replica.disable-empty-write", + "whether to disable empty writes")); + #ifdef DSN_ENABLE_GPERF _cmds.emplace_back(::dsn::command_manager::instance().register_bool_command( _release_tcmalloc_memory, From 5cfddc15857c29eef6d44f5de96339d9564cdb55 Mon Sep 17 00:00:00 2001 From: Dan Wang Date: Wed, 27 Nov 2024 13:34:24 +0800 Subject: [PATCH 2/2] fix --- src/replica/replica_stub.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/replica/replica_stub.cpp b/src/replica/replica_stub.cpp index cad0d4d786..18b5566e63 100644 --- a/src/replica/replica_stub.cpp +++ b/src/replica/replica_stub.cpp @@ -2356,7 +2356,6 @@ void replica_stub::register_ctrl_command() })); _cmds.emplace_back(::dsn::command_manager::instance().register_bool_command( - FLAGS_empty_write_disabled, FLAGS_empty_write_disabled, "replica.disable-empty-write", "whether to disable empty writes"));