Refactor log macros

[acelyc111]

There are two type of log macros in the code, one is using C string format specifiers, like LOG_INFO, the other is using libfmt, like LOG_INFO_F.

It's strange to keep the two macros in long term, I'm planning to refactor them and only leave libfmt style one.

[acelyc111]

Because there are so many code to be modified, I'll separet the whole work into smaller patches to make reviewers happy 😆

• LOG_DEBUG
  • all: refactor(log): use LOG_DEBUG_F instead of LOG_DEBUG #1306
• LOG_INFO
  • replica module: refactor(log): use LOG_INFO_F instead of LOG_INFO (1/3) #1307
  • meta module: refactor(log): use LOG_INFO_F instead of LOG_INFO (2/3) #1310
  • others: refactor(log): use LOG_INFO_F instead of LOG_INFO (3/3) #1311
• LOG_WARN
  • replica module: refactor(log): use LOG_WARNING_F instead of LOG_WARNING (1/3) #1315
  • meta module: refactor(log): use LOG_WARNING_F instead of LOG_WARNING (2/3) #1316
  • others: refactor(log): use LOG_WARNING_F instead of LOG_WARNING (3/3) #1319
• LOG_ERROR
  • replica module: refactor(log): use LOG_ERROR_F instead of LOG_ERROR (1/2) #1318
  • others: refactor(log): use LOG_ERROR_F instead of LOG_ERROR (2/2) #1320
• LOG_FATAL
  • all: refactor(log): use LOG_FATAL_F instead of LOG_FATAL #1312

After all the above work been finished, rename LOG_*_F to LOG_* for all log macros

• refactor(log): rename LOG_*_F to LOG_* for all log macros #1322

[empiredan]

After all LOG_* macros have been replaced with LOG_*_F, would LOG_*_F be renamed as LOG_*? For example, LOG_INFO_F is renamed as LOG_INFO ?

[acelyc111]

After all LOG_* macros have been replaced with LOG_*_F, would LOG_*_F be renamed as LOG_*? For example, LOG_INFO_F is renamed as LOG_INFO ?

Yes, I'm planning to still use LOG_*_F before all refactor work been finished, then remove _F postfix at last in one patch.

[acelyc111]

After all LOG_* macros have been replaced with LOG_*_F, would LOG_*_F be renamed as LOG_*? For example, LOG_INFO_F is renamed as LOG_INFO ?

Yes, I'm planning to still use LOG_*_F before all refactor work been finished, then remove _F postfix at last in one patch.

In this way, all macros with or without _F postfix are both in the same semantics in the progress.

[empiredan]

After all LOG_* macros have been replaced with LOG_*_F, would LOG_*_F be renamed as LOG_*? For example, LOG_INFO_F is renamed as LOG_INFO ?

Yes, I'm planning to still use LOG_*_F before all refactor work been finished, then remove _F postfix at last in one patch.

In this way, all macros with or without _F postfix are both in the same semantics in the progress.

I think it is important to keep all macros consistent without intermediate stages. Let's go ahead !

[Smityz]

Meticulous work!
Can we add some checking of parameter count in the log function?
ref: fmtlib/fmt#2593

[acelyc111]

Meticulous work! Can we add some checking of parameter count in the log function? ref: fmtlib/fmt#2593

I assigned this work to you, you can implement it if you have time.

[acelyc111]

@GehaFearless Could you please to do the remain work?

• LOG_WARN

  • replica module
  • meta module
  • others

• LOG_ERROR

  • replica module
  • others