From 05132734571497222ed88fd8352236aaebdcf8b1 Mon Sep 17 00:00:00 2001
From: wangguangshuo <1924240046@qq.com>
Date: Thu, 18 Jan 2024 03:20:19 +0000
Subject: [PATCH] make both the initMetrics function (some other functions are
 the same) and dataSource as members of Collector

---
 collector/metrics/metric_collector.go | 57 ++++++++++++++-------------
 1 file changed, 29 insertions(+), 28 deletions(-)

diff --git a/collector/metrics/metric_collector.go b/collector/metrics/metric_collector.go
index bb9175affc..17e8baad42 100644
--- a/collector/metrics/metric_collector.go
+++ b/collector/metrics/metric_collector.go
@@ -53,9 +53,6 @@ var GaugeMetricsMap map[string]prometheus.GaugeVec
 var CounterMetricsMap map[string]prometheus.CounterVec
 var SummaryMetricsMap map[string]prometheus.Summary
 
-// RoleByDataSource 0 meta server, 1 replica server.
-var RoleByDataSource map[int]string
-
 var TableNameByID map[string]string
 
 type MetricCollector interface {
@@ -69,19 +66,23 @@ func NewMetricCollector(
 	GaugeMetricsMap = make(map[string]prometheus.GaugeVec, 128)
 	CounterMetricsMap = make(map[string]prometheus.CounterVec, 128)
 	SummaryMetricsMap = make(map[string]prometheus.Summary, 128)
-	RoleByDataSource = make(map[int]string, 128)
 	TableNameByID = make(map[string]string, 128)
-	RoleByDataSource[0] = "meta"
-	RoleByDataSource[1] = "replica"
-	initMetrics(dataSource)
 
-	return &Collector{detectInterval: detectInterval, detectTimeout: detectTimeout, dataSource: dataSource}
+	var role string
+	if dataSource == 0 {
+		role = "meta"
+	} else {
+		role = "replica"
+	}
+	var collector = Collector{detectInterval: detectInterval, detectTimeout: detectTimeout, role: role}
+	collector.initMetrics()
+	return &collector
 }
 
 type Collector struct {
-	dataSource     int
 	detectInterval time.Duration
 	detectTimeout  time.Duration
+	role           string
 }
 
 func (collector *Collector) Start(tom *tomb.Tomb) error {
@@ -92,7 +93,7 @@ func (collector *Collector) Start(tom *tomb.Tomb) error {
 			return nil
 		case <-ticker.C:
 			updateClusterTableInfo()
-			processAllServerMetrics(collector.dataSource)
+			collector.processAllServerMetrics()
 		}
 	}
 }
@@ -123,10 +124,10 @@ func getReplicaAddrs() ([]string, error) {
 }
 
 // Register all metrics.
-func initMetrics(dataSource int) {
+func (collector *Collector) initMetrics() {
 	var addrs []string
 	var err error
-	if dataSource == MetaServer {
+	if collector.role == "meta" {
 		addrs = viper.GetStringSlice("meta_servers")
 	} else {
 		addrs, err = getReplicaAddrs()
@@ -187,10 +188,10 @@ func initMetrics(dataSource int) {
 }
 
 // Parse metric data and update metrics.
-func processAllServerMetrics(dataSource int) {
+func (collector *Collector) processAllServerMetrics() {
 	var addrs []string
 	var err error
-	if dataSource == MetaServer {
+	if collector.role == "meta" {
 		addrs = viper.GetStringSlice("meta_servers")
 	} else {
 		addrs, err = getReplicaAddrs()
@@ -224,7 +225,7 @@ func processAllServerMetrics(dataSource int) {
 					tableID, &metricsByTableID)
 				collectServerLevelTableMetric(entity.Get("metrics").Array(), tableID,
 					&metricsByServerTableID)
-				updateServerLevelTableMetrics(addr, metricsByServerTableID, dataSource)
+				collector.updateServerLevelTableMetrics(addr, metricsByServerTableID)
 			case "server":
 				mergeIntoClusterLevelServerMetric(entity.Get("metrics").Array(),
 					metricsOfCluster)
@@ -236,13 +237,13 @@ func processAllServerMetrics(dataSource int) {
 		}
 	}
 
-	updateClusterLevelTableMetrics(metricsByTableID, dataSource)
-	updateServerLevelServerMetrics(metricsByAddr, dataSource)
-	updateClusterLevelMetrics(metricsOfCluster, dataSource)
+	collector.updateClusterLevelTableMetrics(metricsByTableID)
+	collector.updateServerLevelServerMetrics(metricsByAddr)
+	collector.updateClusterLevelMetrics(metricsOfCluster)
 }
 
 // Update table metrics. They belong to a specified server.
-func updateServerLevelTableMetrics(addr string, metricsByServerTableID map[string]Metrics, dataSource int) {
+func (collector *Collector) updateServerLevelTableMetrics(addr string, metricsByServerTableID map[string]Metrics) {
 	for tableID, metrics := range metricsByServerTableID {
 		var tableName string
 		if name, ok := TableNameByID[tableID]; !ok {
@@ -251,29 +252,29 @@ func updateServerLevelTableMetrics(addr string, metricsByServerTableID map[strin
 			tableName = name
 		}
 		for _, metric := range metrics {
-			updateMetric(metric, addr, "server", tableName, dataSource)
+			collector.updateMetric(metric, addr, "server", tableName)
 		}
 	}
 }
 
 // Update server metrics. They belong to a specified server.
-func updateServerLevelServerMetrics(metricsByAddr map[string]Metrics, dataSource int) {
+func (collector *Collector) updateServerLevelServerMetrics(metricsByAddr map[string]Metrics) {
 	for addr, metrics := range metricsByAddr {
 		for _, metric := range metrics {
-			updateMetric(metric, addr, "server", "server", dataSource)
+			collector.updateMetric(metric, addr, "server", "server")
 		}
 	}
 }
 
 // Update cluster level metrics. They belong to a cluster.
-func updateClusterLevelMetrics(metricsOfCluster []Metric, dataSource int) {
+func (collector *Collector) updateClusterLevelMetrics(metricsOfCluster []Metric) {
 	for _, metric := range metricsOfCluster {
-		updateMetric(metric, "cluster", "server", metric.name, dataSource)
+		collector.updateMetric(metric, "cluster", "server", metric.name)
 	}
 }
 
 // Update table metrics. They belong to a cluster.
-func updateClusterLevelTableMetrics(metricsByTableID map[string]Metrics, dataSource int) {
+func (collector *Collector) updateClusterLevelTableMetrics(metricsByTableID map[string]Metrics) {
 	for tableID, metrics := range metricsByTableID {
 		var tableName string
 		if name, ok := TableNameByID[tableID]; !ok {
@@ -282,13 +283,13 @@ func updateClusterLevelTableMetrics(metricsByTableID map[string]Metrics, dataSou
 			tableName = name
 		}
 		for _, metric := range metrics {
-			updateMetric(metric, "cluster", "table", tableName, dataSource)
+			collector.updateMetric(metric, "cluster", "table", tableName)
 		}
 	}
 }
 
-func updateMetric(metric Metric, endpoint string, level string, title string, dataSource int) {
-	role := RoleByDataSource[dataSource]
+func (collector *Collector) updateMetric(metric Metric, endpoint string, level string, title string) {
+	role := collector.role
 	switch metric.mtype {
 	case "Counter":
 		if counter, ok := CounterMetricsMap[metric.name]; ok {