Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Using tvmop & Restoring tvmop tests & Unlinking libcuda.so #18678

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft

Using tvmop & Restoring tvmop tests & Unlinking libcuda.so #18678

wants to merge 33 commits into from

Conversation

jinboci
Copy link
Contributor

@jinboci jinboci commented Jul 9, 2020

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @jinboci , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, sanity, website, edge, centos-cpu, miscellaneous, windows-cpu, clang, centos-gpu, unix-cpu, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

szha
szha reviewed Jul 9, 2020
View reviewed changes
ci/docker/runtime_functions.sh
@@ -762,6 +765,7 @@ build_ubuntu_gpu_cuda101_cudnn7_make() {
make \
USE_BLAS=openblas \
USE_MKLDNN=0 \
USE_TVM_OP=1 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leezu are the make builds still in use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were kept as various language bindings hadn't been updated for the cmake build. As those were removed recently, we can delete the Makefile without impacting the CI

@jinboci
Copy link
Contributor Author

jinboci commented Jul 10, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

yzhliu
yzhliu reviewed Jul 13, 2020
View reviewed changes
ci/docker/runtime_functions.sh Outdated
@@ -820,6 +843,7 @@ build_ubuntu_gpu_cmake_no_rtc() {
-DUSE_SIGNAL_HANDLER=ON \
-DUSE_CUDA=ON \
-DUSE_CUDNN=ON \
-DUSE_TVM_OP=OFF \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does it fail with TVM_OP=OFF? http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-gpu/branches/PR-18678/runs/3/nodes/59/steps/293/log/?start=0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It used to be on when producing that log.

@jinboci
Copy link
Contributor Author

jinboci commented Jul 13, 2020 •
edited
Loading

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@jinboci jinboci mentioned this pull request Jul 15, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha left review comments

@leezu leezu leezu left review comments

@yzhliu yzhliu yzhliu left review comments

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu will be requested when the pull request is marked ready for review marcoabreu is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham will be requested when the pull request is marked ready for review aaronmarkham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jinboci @mxnet-bot @yzhliu @leezu @szha