Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KOGITO-2005] - Prepare master branch for the next iteration. #184

Merged
merged 1 commit into from
Jun 22, 2020
Merged

[KOGITO-2005] - Prepare master branch for the next iteration. #184

merged 1 commit into from
Jun 22, 2020

Conversation

spolti
Copy link
Member

@spolti spolti commented Jun 17, 2020 •
edited
Loading

Prepare master branch for the next iteration.

See https://issues.redhat.com/browse/KOGITO-2005

Signed-off-by: spolti [email protected]

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@spolti spolti added the needs review 🔍 Pull Request that needs reviewers label Jun 17, 2020
@spolti spolti added this to the v0.12.0 milestone Jun 17, 2020
@spolti spolti changed the base branch from master to 0.11.x June 17, 2020 15:04
@spolti spolti changed the base branch from 0.11.x to master June 17, 2020 15:04
@spolti
[KOGITO-2005] - Release Kogito Images 0.11.0
11c534b 
Prepare master branch for the next iteration.

See https://issues.redhat.com/browse/KOGITO-2005

Signed-off-by: spolti <[email protected]>
@radtriste
Copy link
Contributor

Just thinking ... Could we have a follow-up image instead ?
Title is confusing as we are setting to the next version and not 0.11.0 ...

vaibhavjainwiz
vaibhavjainwiz reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@vaibhavjainwiz vaibhavjainwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaibhavjainwiz vaibhavjainwiz self-requested a review June 22, 2020 04:16
@spolti
Copy link
Member Author

spolti commented Jun 22, 2020

g to the next version and not 0.11.0 ...

Didn't understand, what do you meant by followup image?
the commit description has a message telling that its purpose is to prepare master branch for the next iteration/version.

@spolti spolti added the ready 🚀 PR is ready to be merged label Jun 22, 2020
@spolti spolti merged commit cafe40e into apache:master Jun 22, 2020
@spolti spolti deleted the KOGITO-2005 branch June 22, 2020 17:48
@radtriste
Copy link
Contributor

@spolti I meant that the title of the PR is confusing regarding its content. We should change the way we are naming those as here, this is not the release but the set to the next version

@spolti spolti removed the needs review 🔍 Pull Request that needs reviewers label Jun 29, 2020
@spolti spolti changed the title [KOGITO-2005] - Release Kogito Images 0.11.0 [KOGITO-2005] - Prepare master branch for the next iteration. Jun 29, 2020
@kie-ci3 kie-ci3 mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaitou786 Kaitou786 Kaitou786 approved these changes

@vaibhavjainwiz vaibhavjainwiz vaibhavjainwiz approved these changes

@sutaakar sutaakar sutaakar approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

@radtriste radtriste Awaiting requested review from radtriste

Assignees
No one assigned
Labels
ready 🚀 PR is ready to be merged
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@spolti @radtriste @ricardozanini @sutaakar @vaibhavjainwiz @Kaitou786