From 9a97d8310b7712666438eece2e5113d67db9f9e7 Mon Sep 17 00:00:00 2001 From: Jermy Li Date: Fri, 15 Apr 2022 13:11:57 +0800 Subject: [PATCH 1/2] correct how to sign the CLA --- CONTRIBUTING.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 139ba8d21a..1887fccbc4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,8 +36,6 @@ Before submitting the code, we need to do some preparation: git config user.email "{email-address-of-github}" # like "jermy@apache.org" ``` -5. Sign the HugeGraph CLA: [https://cla-assistant.io/hugegraph/hugegraph](https://cla-assistant.io/hugegraph/hugegraph) - Optional: You can use [GitHub desktop](https://desktop.github.com/) to greatly simplify the commit and update process. ## 2. Create an Issue on GitHub @@ -107,6 +105,13 @@ git push origin bugfix-branch:bugfix-branch Go to the web page of GitHub fork repo, there would be a chance to create a Pull Request after pushing to a new branch, just click button "Compare & pull request" to do it. Then edit the description for proposed changes, which can just be copied from the commit message. +Please sign the HugeGraph CLA when contributing code for the first time. You can sign the CLA by just posting a Pull Request Comment same as the below format: + +`I have read the CLA Document and I hereby sign the CLA` + +Note that please make sure the email address you submit the code is bound to the GitHub account. For how to bind the email address, please refer to https://github.com/settings/emails: +image + ## 5. Code review Maintainers will start the code review after all the **automatic** checks are passed: From 256fb57594877281d3aac6ae540b9a8c7633cb62 Mon Sep 17 00:00:00 2001 From: Jermy Li Date: Sat, 16 Apr 2022 11:54:48 +0800 Subject: [PATCH 2/2] improve note --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1887fccbc4..d5b096b5a8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -109,7 +109,7 @@ Please sign the HugeGraph CLA when contributing code for the first time. You can `I have read the CLA Document and I hereby sign the CLA` -Note that please make sure the email address you submit the code is bound to the GitHub account. For how to bind the email address, please refer to https://github.com/settings/emails: +Note: please make sure the email address you used to submit the code is bound to the GitHub account. For how to bind the email address, please refer to https://github.com/settings/emails: image ## 5. Code review