Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Dockerfile misc problems #2343

Open
1 task done
aroundabout opened this issue Nov 8, 2023 · 1 comment
Open
1 task done

[Question] Dockerfile misc problems #2343

aroundabout opened this issue Nov 8, 2023 · 1 comment
Labels
ci-cd Build or deploy help wanted Extra attention is needed improvement General improvement

Comments

@aroundabout
Copy link
Contributor

aroundabout commented Nov 8, 2023

Problem Type (问题类型)

performance (性能优化) subtask of #840

Before submit

  • 我已经确认现有的 IssuesFAQ 中没有相同 / 重复问题 (I have confirmed and searched that there are no similar problems in the historical issue and documents)

Environment (环境信息)

  • Server Version: 1.0.0 (Apache Release Version)
  • Backend: RocksDB x nodes, HDD or SSD
  • OS: xx CPUs, xx G RAM, Ubuntu 2x.x / CentOS 7.x
  • Data Size: xx vertices, xx edges

Your Question (问题描述)

In the current Dockerfile, we use a shell to run three shell in order:

ENTRYPOINT ["/usr/bin/dumb-init", "--"]
CMD ["./docker-entrypoint.sh"]

In docker-entrypoint.sh

./bin/wait-storage.sh
./bin/init-store.sh
./bin/start-hugegraph.sh -d false -j "$JAVA_OPTS" -g zgc

There are some question:

  1. Can the dumb-init work correctly or does it still make sense to use dumb-init
  2. If the server is down, will the container exit or not
  3. If the container is down, users should do what to restart the container? If they use docker start, docker will do wait-storage and init-store again. And if docker start, is the expected result consistent with the actual one?
  4. The name of docker-entrypoint.sh seems to be inappropriate

Vertex/Edge example (问题点 / 边数据举例)

No response

Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)

No response

@imbajin imbajin changed the title [Question] describe your problem [Question] Dockerfile misc problems Nov 9, 2023

This comment was marked as outdated.

@imbajin imbajin added improvement General improvement help wanted Extra attention is needed ci-cd Build or deploy and removed inactive labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy help wanted Extra attention is needed improvement General improvement
Projects
None yet
Development

No branches or pull requests

2 participants