Skip to content

Commit

Permalink
chore: bump Dockerfile SERVER_VERSION to 0.12.0 (#1901)
Browse files Browse the repository at this point in the history
  • Loading branch information
@simon824
simon824 authored Jun 25, 2022
1 parent 3328964 commit b54fba6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ RUN set -x \
# 2. Init HugeGraph Sever
# (Optional) You can set the ip of github to speed up the local build
# && echo "192.30.253.112 github.com\n151.101.44.249 github.global.ssl.fastly.net" >> /etc/hosts \
ENV SERVER_VERSION 0.10.4
ENV SERVER_VERSION 0.12.0
RUN set -e \
&& mkdir -p /root/hugegraph-server \
&& curl -L -S ${PKG_URL}/hugegraph/releases/download/v${SERVER_VERSION}/hugegraph-${SERVER_VERSION}.tar.gz -o /root/server.tar.gz \
&& tar xzf /root/server.tar.gz --strip-components 1 -C /root/hugegraph-server \
&& rm /root/server.tar.gz \
&& cd /root/hugegraph-server/ \
&& sed -i "s/^restserver.url.*$/restserver.url=http:\/\/0.0.0.0:8080/g" ./conf/rest-server.properties \
&& sed -n '63p' ./bin/start-hugegraph.sh | grep "&" > /dev/null && sed -i 63{s/\&$/#/g} ./bin/start-hugegraph.sh \
&& sed -n '74p' ./bin/start-hugegraph.sh | grep "exit" > /dev/null && sed -i 74{s/^/#/g} ./bin/start-hugegraph.sh \
&& sed -n '65p' ./bin/start-hugegraph.sh | grep "&" > /dev/null && sed -i 65{s/\&$/#/g} ./bin/start-hugegraph.sh \

This comment has been minimized.

Sign in to view

Copy link
@baughmann

baughmann Nov 12, 2022

In my experience as an outsider, this is one line off. Should be 66, which corresponds to line with content

${OPEN_SECURITY_CHECK} ${USER_OPTION} ${GC_OPTION} >>${LOGS}/hugegraph-server.log 2>&1 &

in the properties file

This comment has been minimized.

Sign in to view

Copy link
@imbajin

imbajin Nov 28, 2022

Member

In my experience as an outsider, this is one line off. Should be 66, which corresponds to line with content

${OPEN_SECURITY_CHECK} ${USER_OPTION} ${GC_OPTION} >>${LOGS}/hugegraph-server.log 2>&1 &

in the properties file

refer to the code, seems it should be Line65? And I try to test it in a clean env now

incubator-hugegraph/hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh

Line 65 in f17a68a

${OPEN_SECURITY_CHECK} ${USER_OPTION} ${GC_OPTION} >>${LOGS}/hugegraph-server.log 2>&1 &

&& sed -n '75p' ./bin/start-hugegraph.sh | grep "exit" > /dev/null && sed -i 75{s/^/#/g} ./bin/start-hugegraph.sh \

This comment has been minimized.

Sign in to view

Copy link
@baughmann

baughmann Nov 12, 2022

In my experience building this, this was one line off. Should be 76, which corresponds with to line with content

    exit 1

This comment has been minimized.

Sign in to view

Copy link
@imbajin

imbajin Nov 28, 2022

Member

seems the same situation:

incubator-hugegraph/hugegraph-dist/src/assembly/static/bin/start-hugegraph.sh

Line 75 in f17a68a

exit 1

&& ./bin/init-store.sh

# 3. Prepare for HugeGraph Studio
Expand Down

1 comment on commit b54fba6

@baughmann
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on lines 30 and 31. You can recreate my situation by just copying the content of this Dockerfile to a new text document in a directory on Linux and running docker build .

I would be happy to submit a PR on this, but I want to make sure I'm not off base here before doing so.

Please sign in to comment.