disable delimiter parsing when construct from MapConfiguration #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 88.53% 88.66% +0.12%
- Complexity 922 924 +2
============================================
Files 63 63
Lines 2705 2708 +3
Branches 395 396 +1
============================================
+ Hits 2395 2401 +6
+ Misses 161 159 -2
+ Partials 149 148 -1
Continue to review full report at Codecov.
|
javeme
reviewed
Apr 26, 2021
|
|
||
| if (config instanceof MapConfiguration) { | ||
| ((MapConfiguration) config).setDelimiterParsingDisabled(true); | ||
| } |
javeme
reviewed
Apr 26, 2021
| @@ -62,10 +59,12 @@ public HugeConfig(String configFile) { | |||
| } | |||
|
|
|||
| private void reloadIfNeed(Configuration conf) { | |||
| if (conf instanceof MapConfiguration) { | |||
| ((MapConfiguration) conf).setDelimiterParsingDisabled(true); | |||
| } | |||
javeme
approved these changes
Apr 26, 2021
Linary
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.