Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency conflict "InjectionManagerFactory not found" #10

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Dec 18, 2018

Fix #9

Change-Id: I83f2074c431994f72a62e37ab4a6086c3142a1b5

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #10 into master will increase coverage by 1.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   22.97%   24.04%   +1.06%     
==========================================
  Files          43       43              
  Lines        1262     1277      +15     
  Branches      227      229       +2     
==========================================
+ Hits          290      307      +17     
+ Misses        944      937       -7     
- Partials       28       33       +5
Impacted Files Coverage Δ
...ava/com/baidu/hugegraph/version/CommonVersion.java 50% <100%> (+50%) ⬆️
...ain/java/com/baidu/hugegraph/util/VersionUtil.java 60.56% <73.33%> (+12.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476bb78...8fcb8ba. Read the comment docs.

javeme
javeme previously approved these changes Dec 21, 2018
@Linary Linary force-pushed the add-dependency-hk2 branch 2 times, most recently from 633357e to 166013b Compare December 21, 2018 03:00
javeme
javeme previously approved these changes Dec 21, 2018
@javeme
Copy link
Contributor

javeme commented Dec 21, 2018

@Linary Linary force-pushed the add-dependency-hk2 branch 3 times, most recently from eaa63af to 0d1a637 Compare December 24, 2018 06:31
Fix #9

Change-Id: I83f2074c431994f72a62e37ab4a6086c3142a1b5
@Linary Linary force-pushed the add-dependency-hk2 branch from 0d1a637 to 8fcb8ba Compare December 24, 2018 06:50
@zhoney zhoney merged commit 6f20cb8 into master Dec 24, 2018
@zhoney zhoney deleted the add-dependency-hk2 branch December 24, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants