Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Upgrading Bazel to 3.0.0 #3510

Merged
merged 57 commits into from
Apr 16, 2020
Merged

Conversation

nicknezis
Copy link
Contributor

Update the Bazel build scripts to use this new capability: https://github.com/bazelbuild/rules_jvm_external

The goal would be to better manage the project's dependencies and not have to manually update the various transitive dependencies. This tool will use a dependency's pom.xml to dynamically generate the Bazel targets for each of the dependencies.

This approach started with the buildozer migration which did a lot of formatting cleanup, but ultimately didn't work. After the buildozer cleanup, I had to manually update the WORKSPACE and BUILD files to use the new maven_install feature.

@nicknezis nicknezis marked this pull request as ready for review April 15, 2020 05:54
Copy link
Member

@joshfischer1108 joshfischer1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Before this `scripts/travis/test.sh` was not working when run in a container.
Copy link
Contributor

@nwangtw nwangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of work! Thanks!

@nicknezis nicknezis merged commit 2a4f112 into apache:master Apr 16, 2020
@nicknezis nicknezis deleted the nicknezis/bazel-upgrade branch April 16, 2020 05:19
nicknezis added a commit that referenced this pull request Sep 14, 2020
* Bazel 3.0.0
* Updated to use `rules_jvm_external`
* Buildozer cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants