This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Heron Pom files should have proper dependencies listed. #3774
Labels
Apache Release
For tasks to meet Apache release requirements
One of the issues was that we are shading dependencies into the jar. We should instead be providing the jar with only our code, and the pom.xml should include the dependencies.
The scripts to generate the pom.xml files:
https://github.com/apache/incubator-heron/tree/master/scripts/ci
And the scripts to build the Heron API jar(s):
incubator-heron/heron/api/src/java/BUILD
Lines 23 to 87 in abb2767
"api-java-low-level": Normal "Topology API" jar
"api-java": Functional (i.e. Streamlet jar)
"api-java-low-level-functional": Combination of topology and streamlet code
"api-unshaded": Java Binary (why a binary???) with both, but kryo neverlink
dependency added. I think this might be for Storm compatibility?
"api-shaded": Remaps the protobuf classes based on this rule... but the
rule doesn't shade any of the other dependencies... If we will continue
shading, we should fix this.
https://github.com/apache/incubator-heron/blob/master/heron/api/src/java/shade.conf
"heron-api": We create a copy of the heron-api.jar for some reason... no
idea why this is this way and we don't just rename the previouis build task
"classification": No idea what this is... is it part of the Heron API? Why
is it not included in the resulting "heron-api" jar?
Questions I have:
dependencies in the pom.xml?
examples are referencing the more immediate streamlet or low-level jars.
Should the examples reference that final jar?
The text was updated successfully, but these errors were encountered: