Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Fix heronrc/heron parser #1595

Closed
objmagic opened this issue Dec 6, 2016 · 2 comments · Fixed by #1767
Closed

Fix heronrc/heron parser #1595

objmagic opened this issue Dec 6, 2016 · 2 comments · Fixed by #1767

Comments

@objmagic
Copy link
Contributor

objmagic commented Dec 6, 2016

Heron RC parser introduced by #1119 is full of design and implementation flaw and confusion, even after my dozens of comments. It could be a good PR if I close the original PR and rewrite one completely. Even fixing this parser feels like patching an already sinking ship.

Bug 1: #1257, which has been fixed. But my last comment is still not answered.

Bug 2: some obviously invalid patterns are not rejected. For example, heron now accepts arbitrary number of parameters after action (subcommand).

Since I am back working on cli tool again, I might find some time to clean up this tech debt.

@objmagic
Copy link
Contributor Author

objmagic commented Dec 7, 2016

@kramasamy any comment on this issue?

@objmagic
Copy link
Contributor Author

although it is hard to work on/maintain heronrc parser, it works alright. let's delay this issue...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant