Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c++): Find a better uri parser for GraphAr, remove the rely on arrow::internal::URI #459

Closed
acezen opened this issue Apr 22, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@acezen
Copy link
Contributor

acezen commented Apr 22, 2024

Is your feature request related to a problem? Please describe.
currently, we use arrow::internal::URI to parse and check the uri string, but it is part of the Apache Arrow C++ library's internal API, which is not intended for direct use by end-users. The internal API is subject to change without notice, and its use is not recommended for production code.

We should find a third-party URI parse library to replace the arrow::internal::URI.

Describe the solution you'd like
Since GraphAr has already rely on Boost library. To avoid include other dependency, it's better to use Boost::URL.

Boost::URL in not available in boost library before 2023, considering use a light-weight single header parser like simple-uri-parser

@acezen acezen added the enhancement New feature or request label Apr 22, 2024
@acezen acezen self-assigned this Apr 22, 2024
@acezen acezen changed the title feat(c++): Replace the arrow::internal::URI with Boost::URL feat(c++): Find a better uri parser for GraphAr, remove the rely on arrow::internal::URI Apr 23, 2024
@acezen acezen closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant