Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Json support in Gluten/Velox tracker #5504

Open
PHILO-HE opened this issue Apr 23, 2024 · 3 comments
Open

[VL] Json support in Gluten/Velox tracker #5504

PHILO-HE opened this issue Apr 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Apr 23, 2024

Currently only get_json_object function is supported.

The below tests are disabled in #5467. We need to re-enable them after facebookincubator/velox#5179 is merged.

// runTest("[1,2,3]", "$0",
// runTest("[1,2,3]", "$",
// runTest("{"a":4}", "$",

BTW, see how wilcard is supported for presto: facebookincubator/velox@4e075a0

@FelixYBW
Copy link
Contributor

What's the json functions Gluten already support? Here is the list:

json func desc
from_json() Converts JSON string into Struct type or Map type.
to_json() Converts MapType or Struct type to JSON string.
json_tuple() Extract the Data from JSON and create them as a new columns.
get_json_object() Extracts JSON element from a JSON string based on json path specified.
schema_of_json() Create schema string from JSON string

With supported function, what's the syntax gap? Could you put a list?

@PHILO-HE
Copy link
Contributor Author

What's the json functions Gluten already support? Here is the list:

json func desc
from_json() Converts JSON string into Struct type or Map type.
to_json() Converts MapType or Struct type to JSON string.
json_tuple() Extract the Data from JSON and create them as a new columns.
get_json_object() Extracts JSON element from a JSON string based on json path specified.
schema_of_json() Create schema string from JSON string

Hi @FelixYBW, currently only get_json_object is supported.

With supported function, what's the syntax gap? Could you put a list?

We have one issue already created to track result mismatched issue: #4652. I will also help update that issue list.

@FelixYBW FelixYBW changed the title [VL] Enable some json test cases [VL] Json support in Gluten/Velox tracker May 7, 2024
@FelixYBW
Copy link
Contributor

FelixYBW commented May 7, 2024

#5600 add json_tuple function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants