Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The fields need to be made final #980

Closed
2 tasks done
kirinzhu opened this issue Jul 1, 2022 · 2 comments
Closed
2 tasks done

[BUG] The fields need to be made final #980

kirinzhu opened this issue Jul 1, 2022 · 2 comments
Assignees
@liuzwei
Labels
bug Something isn't working easy to fix
Milestone
1.6.0

Comments

@kirinzhu
Copy link
Contributor

kirinzhu commented Jul 1, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Mac

EventMesh version

master

What happened

There are many fields which are static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.

How to reproduce

It may be changed from another package

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@kirinzhu kirinzhu added the bug Something isn't working label Jul 1, 2022
@kirinzhu kirinzhu changed the title [Bug] The fields need to be made final [Enhancement] The fields need to be made final Jul 1, 2022
@kirinzhu kirinzhu changed the title [Enhancement] The fields need to be made final [BUG] The fields need to be made final Jul 1, 2022
@Alonexc Alonexc mentioned this issue Jul 5, 2022
Open
@liuzwei
Copy link
Contributor

liuzwei commented Jul 9, 2022

I want to fix this issue!

@kirinzhu
Copy link
Contributor Author

kirinzhu commented Jul 9, 2022

I want to fix this issue!

Welcome!

liuzwei added a commit to liuzwei/incubator-eventmesh that referenced this issue Jul 10, 2022
@liuzwei
[ISSUE apache#980] Made some fields are final
7c3baba
liuzwei added a commit to liuzwei/incubator-eventmesh that referenced this issue Jul 10, 2022
@liuzwei
[ISSUE apache#980] Made some fields are final
0cba0e7
@liuzwei liuzwei mentioned this issue Jul 10, 2022
Closed
liuzwei added a commit to liuzwei/incubator-eventmesh that referenced this issue Jul 12, 2022
@liuzwei
[ISSUE apache#980]Made some fileds are final
ed32988
@liuzwei liuzwei mentioned this issue Jul 12, 2022
Merged
@xwm1992 xwm1992 added this to the 1.6.0 milestone Jul 12, 2022
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
@liuzwei
[ISSUE #980]Made some fileds are final
d430ed9
xwm1992 added a commit that referenced this issue Aug 4, 2022
@xwm1992
Merge pull request #1015 from liuzwei/fix_bug#980
229ad5e 
[ISSUE #980]Made some fileds are final
close #980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuzwei liuzwei

Labels
bug Something isn't working easy to fix
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
4 participants
@liuzwei @xwm1992 @qqeasonchen @kirinzhu