Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support custom retry times configuration when SubcriptionType is SYNC #460

Closed
lrhkobe opened this issue Jul 23, 2021 · 0 comments · Fixed by #463
Closed

[Enhancement] Support custom retry times configuration when SubcriptionType is SYNC #460

lrhkobe opened this issue Jul 23, 2021 · 0 comments · Fixed by #463
Labels
enhancement New feature or request
Milestone

Comments

@lrhkobe
Copy link
Contributor

lrhkobe commented Jul 23, 2021

Enhancement Request

EventMesh support custom retry times configuration when SubcriptionType is ASYNC, but hard-coded when SubcriptionType is SYNC.

public void pushRetry(DownStreamMsgContext downStreamMsgContext) {
	
	...
	int maxRetryTimes = SubcriptionType.SYNC.equals(downStreamMsgContext.subscriptionItem.getType()) ? 1 : eventMeshTCPServer.getEventMeshTCPConfiguration().eventMeshTcpMsgRetryTimes;
	...
}

Describe the solution you'd like

Add custom configuration in eventmesh.properties refer to config when the SubcriptionType is ASYNC.

@lrhkobe lrhkobe added the enhancement New feature or request label Jul 23, 2021
ruanwenjun added a commit to ruanwenjun/incubator-eventmesh that referenced this issue Jul 24, 2021
xwm1992 pushed a commit that referenced this issue Jul 28, 2021
…Type is SYNC (#463)

* [ISSUE #460]Support custom retry times configuration when SubcriptionType is SYNC

* fix log args
@xwm1992 xwm1992 added this to the 1.3.0 milestone Dec 16, 2021
@xwm1992 xwm1992 changed the title Support custom retry times configuration when SubcriptionType is SYNC [Enhancement] Support custom retry times configuration when SubcriptionType is SYNC Dec 16, 2021
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
…iptionType is SYNC (apache#463)

* [ISSUE apache#460]Support custom retry times configuration when SubcriptionType is SYNC

* fix log args
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
…Type is SYNC (#463)

* [ISSUE #460]Support custom retry times configuration when SubcriptionType is SYNC

* fix log args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants