Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use revision in pom.xml of dubbo-metadata-report-etcd #3980

Merged
merged 1 commit into from
May 5, 2019

Conversation

zhaixiaoxiang
Copy link
Contributor

What is the purpose of the change

change 2.7.2-SNAPSHOT to revision in pom.xml of dubbo-metadata-report-etcd, otherwise there are maven package failures as following:

[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for org.apache.dubbo:dubbo-metadata-report-etcd:2.7.2-SNAPSHOT: Could not find artifact org.apache.dubbo:dubbo-metadata-report:pom:2.7.2-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 22, column 13
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.apache.dubbo:dubbo-metadata-report-etcd:2.7.2-SNAPSHOT (~/gh-incubator-dubbo/dubbo-metadata-report/dubbo-metadata-report-etcd/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for org.apache.dubbo:dubbo-metadata-report-etcd:2.7.2-SNAPSHOT: Could not find artifact org.apache.dubbo:dubbo-metadata-report:pom:2.7.2-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 22, column 13 -> [Help 2]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException

@codecov-io
Copy link

Codecov Report

Merging #3980 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3980      +/-   ##
============================================
+ Coverage     63.82%   63.85%   +0.02%     
  Complexity       71       71              
============================================
  Files           722      722              
  Lines         31812    31852      +40     
  Branches       5088     5115      +27     
============================================
+ Hits          20305    20340      +35     
- Misses         9165     9175      +10     
+ Partials       2342     2337       -5
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0%> (-3.85%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0%> (-2%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-1.54%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 68.42% <0%> (-1.23%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyClient.java 66.1% <0%> (-1.14%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty4/NettyClient.java 70.58% <0%> (-1.06%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <0%> (-0.92%) 0% <0%> (ø)
.../main/java/org/apache/dubbo/qos/textui/TTable.java 83.79% <0%> (-0.87%) 0% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b30bddb...7649833. Read the comment docs.

@lovepoem
Copy link
Member

lovepoem commented May 5, 2019

LGTM

@lovepoem lovepoem merged commit c98abb2 into apache:master May 5, 2019
@cvictory cvictory added this to the 2.7.2 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants