Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve:change serviceMetadata order #3754

Merged
merged 3 commits into from
Apr 23, 2019
Merged

improve:change serviceMetadata order #3754

merged 3 commits into from
Apr 23, 2019

Conversation

qinliujie
Copy link
Contributor

What is the purpose of the change

change service metadata init order, so that we can use service metadata when ServiceConfig/ReferenceConfig init

Brief changelog

change service metadata init order

Copy link
Contributor

@Jeff-Lv Jeff-Lv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@ralf0131
Copy link
Contributor

ralf0131 commented Apr 5, 2019

@Jeff-Lv You can merge it if you feel confident. Do you still want others to review?

Copy link
Contributor

@Jeff-Lv Jeff-Lv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants