From 1ef9f8b646a15f8357c44698f0855b64a61c0ee4 Mon Sep 17 00:00:00 2001 From: Lynwee Date: Mon, 26 Feb 2024 17:33:57 +0800 Subject: [PATCH] fix(gitextractor): cover errors that may leak sensitive information (#7018) --- backend/plugins/gitextractor/parser/clone.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/backend/plugins/gitextractor/parser/clone.go b/backend/plugins/gitextractor/parser/clone.go index 2e7576284f9..ba04429ca9d 100644 --- a/backend/plugins/gitextractor/parser/clone.go +++ b/backend/plugins/gitextractor/parser/clone.go @@ -121,6 +121,8 @@ func (l *GitRepoCreator) CloneOverHTTP(ctx plugin.SubTaskContext, repoId, url, u _, err := gogit.PlainCloneContext(ctx.GetContext(), dir, true, cloneOptions) done <- struct{}{} if err != nil { + // Some sensitive information such as password will be released in this err. + err = fmt.Errorf("plain clone git error") l.logger.Error(err, "PlainCloneContext") return nil, err }