Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][AzureDevopos] When creating a new connection, allowing the same name to exist does not meet the expectations. #6818

Closed
2 of 3 tasks
xiaomingzhang12 opened this issue Jan 16, 2024 · 4 comments · Fixed by #6911
Assignees
Labels
type/bug This issue is a bug
Milestone

Comments

@xiaomingzhang12
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Select the Azure DevOps plugin and create a new connection, naming this connection 'Azure'.

Create another new connection, also naming this connection 'Azure'.

Click 'save connection'. The creation is successful. After creating three times, the effect is as shown in the picture:
image

The problem with this situation is: Based on the current circumstances, it is not easy to select when associating connections with projects.

What do you expect to happen

Expectation: Similar to the handling with the Jira plugin, when the name is the same as an existing connection name, the interface/api/plugins/azuredevops/connections should give an error message. Below is an example from Jira:
image

How to reproduce

See above

Anything else

No response

Version

main

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@xiaomingzhang12 xiaomingzhang12 added the type/bug This issue is a bug label Jan 16, 2024
@keon94
Copy link
Contributor

keon94 commented Jan 17, 2024

@klesh There's no uniqueness index on the name fields of Azure connections. This can be added via migrations but what do you want to do about existing duplicates? We can't really automate deleting them: how do we know which ones to delete? How do you want to tell the user they have to delete duplicates before migrations can proceed? Just error out?

@klesh
Copy link
Contributor

klesh commented Jan 17, 2024

@keon94 I see. How about we rename them automatically? For example, lets say there were 3 "xxx", we could rename them to "xxx" "xxx - 1" and "xxx - 2" before adding the unique index in the migration script. is it doable?

@keon94
Copy link
Contributor

keon94 commented Jan 17, 2024

@klesh That's a smart solution. Yes, that should be doable.

@keon94
Copy link
Contributor

keon94 commented Feb 2, 2024

PR: #6911

@keon94 keon94 added this to the v0.21 milestone Feb 2, 2024
@d4x1 d4x1 closed this as completed in #6911 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants