[Bug][Gitlab] Deployable.Commit.Message can be bigger than 255

[antoniomuso]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

Pipeline crash when Deployable.Commit.Message is bigger than 255:

incubator-devlake/backend/plugins/gitlab/tasks/deployment_extractor.go

Line 102 in c1e0310

DeployableCommitMessage: r.Deployable.Commit.Message,

What do you expect to happen

Pipeline is executed without crash.

How to reproduce

You can reproduce by adding into GitLab a commit message bigger than 255.

Anything else

No response

Version

v0.20.0-beta1

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[Startrekzky]

Hi @antoniomuso , do you mean that you have a commit message longer than 255? How did that happen?

[antoniomuso]

I don't know, but I have it. Maybe the commit message includes the commit body.

[Startrekzky]

@antoniomuso May I know why the commit message included the commit body? I asked because IDEs like vscode will limit the length of the commit message. I'm trying to figure out the root reason for this and evaluate how common this problem is.

[antoniomuso]

@Startrekzky If you see in the GitLab API, you can see that deployable.commit.message includes the commit title and the commit body. For this reason, it can be longer than 255.

// This example is taken from Gitlab API documentation
{
    "created_at": "2016-08-11T11:32:35.444Z",
    "updated_at": "2016-08-11T11:34:01.123Z",
    "status": "created",
    "deployable": {
      "commit": {
        "author_email": "[email protected]",
        "author_name": "Administrator",
        "created_at": "2016-08-11T13:28:26.000+02:00",
        "id": "a91957a858320c0e17f3a0eca7cfacbff50ea29a",
>        "message": "Merge branch 'rename-readme' into 'main'\r\n\r\nRename README\r\n\r\n\r\n\r\nSee merge request !2",
        "short_id": "a91957a8",
        "title": "Merge branch 'rename-readme' into 'main'\r"
      },
 ...
 }

[moritz-deissner-turbinekreuzberg]

i our case renovate bot is the talkative culprit

[abeizn]

This issue is the precursor to #6521. I will fix it later.

[abeizn]

@antoniomuso It will take effect in v0.20.0-beta4: https://github.com/apache/incubator-devlake/releases/tag/v0.20.0-beta4