Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA - "As a lake developer, I want migrations run when I run make dev" #1008

Closed
1 task done
Tracked by #979
kevin-kline opened this issue Dec 24, 2021 · 1 comment
Closed
1 task done
Tracked by #979

Comments

@kevin-kline
Copy link
Contributor

kevin-kline commented Dec 24, 2021

This is a QA test case for #979

Here is the test procedure I conducted. Changes have been pushed to migrations-v2

QA Flow - Dev

  • Clone repo
  • Switch to migration branch
  • Copy .env file
  • Run make compose (mysql, Grafana)
  • DBs get created without tables from running docker-compose-startup.sql script

SCHEMAS

  • unexpected: Where are the schema migrations tables?
  • Trying again by dropping tables manually
  • Same result
  • Creating tables manually with mysql -u root --protocol=tcp -padmin -h localhost -e "USE lake; CREATE TABLE IF NOT EXISTS schema_migrations (version bigint NOT NULL DEFAULT 1,dirty tinyint(1) NOT NULL DEFAULT 0, PRIMARY KEY (version)) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;”

SCHEMAS

  • Running make dev to see migrations
  • Received 2 errors on migrations:

devlake

  • Paths are wrong:
    • /Users/kevinkline/Merico/test/devlake/bin/lake/db/migration/.
    • /Users/kevinkline/Merico/test/devlake/plugins/compound/migration/.
  • Changed MIGRATIONS_PATH to fix
  • Now 2 errors:

Building plugin github to binpluginsgithubgithub  so

  • 2nd one is caused by the fact there IS no migration folder for compound

plugins

  • Fix added to check if path exists
  • Only error now:

INFO RunDomainLayerMigrationsUp Could not run migrations UP no change

  • However, all tables are migrated:

feishu_meeting_top_user_items

  • This satisfies the following condition:
 “As a lake developer, I want migrations run when I run make dev”
@kevin-kline kevin-kline linked a pull request Dec 24, 2021 that will close this issue
@klesh
Copy link
Contributor

klesh commented May 12, 2022

Resolved by #1057

@klesh klesh closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants